pjfanning commented on code in PR #940:
URL: https://github.com/apache/pekko-http/pull/940#discussion_r2735742038
##########
http-cors/src/main/scala/org/apache/pekko/http/cors/javadsl/settings/CorsSettings.scala:
##########
@@ -47,6 +47,7 @@ abstract class CorsSettings { self: CorsSettingsImpl =>
def withAllowCredentials(newValue: Boolean): CorsSettings
def withAllowedOrigins(newValue: HttpOriginMatcher): CorsSettings
def withAllowedHeaders(newValue: HttpHeaderRange): CorsSettings
+ def withAdditionalAllowedHeaders(newValue: HttpHeaderRange): CorsSettings
Review Comment:
Why do we need this? Can't you concat 2 HttpHeaderRanges based on another
change in this PR? So then you can use the existing withAllowedHeaders to add
the concatenated result.
If we absolutely must also have this extra method, it would be better named
'appendAllowedHeaders'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
