timw commented on code in PR #940:
URL: https://github.com/apache/pekko-http/pull/940#discussion_r2736100937
##########
http-cors/src/main/scala/org/apache/pekko/http/cors/javadsl/settings/CorsSettings.scala:
##########
@@ -47,6 +47,7 @@ abstract class CorsSettings { self: CorsSettingsImpl =>
def withAllowCredentials(newValue: Boolean): CorsSettings
def withAllowedOrigins(newValue: HttpOriginMatcher): CorsSettings
def withAllowedHeaders(newValue: HttpHeaderRange): CorsSettings
+ def withAdditionalAllowedHeaders(newValue: HttpHeaderRange): CorsSettings
Review Comment:
It’s not strictly required - just a little nicer syntax than:
`WebHandler.defaultCorsSettings.withAllowedHeaders(WebHandler.defaultCorsSettings.allowedHeaders
++ otherHeaders)`
So not material to the use case - happy to leave it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
