[ 
https://issues.apache.org/jira/browse/RYA-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105468#comment-16105468
 ] 

ASF GitHub Bot commented on RYA-318:
------------------------------------

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/188#discussion_r130145866
  
    --- Diff: 
common/rya.api/src/main/java/org/apache/rya/api/client/ExecuteSparqlQuery.java 
---
    @@ -0,0 +1,39 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.rya.api.client;
    +
    +import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
    +import edu.umd.cs.findbugs.annotations.NonNull;
    +
    +/**
    + * Loads a SPARQL Query and executes the query against an instance of Rya.
    + */
    +@DefaultAnnotation(NonNull.class)
    +public interface ExecuteSparqlQuery {
    +    /**
    +     * Loads a SPARQL Query and executes the query against an instance of 
Rya.
    +     *
    +     * @param ryaInstanceName - The name of the Rya instance the query 
will be executed against. (not null)
    +     * @param sparqlQuery - A single SPARQL Query. (not null)
    +     * @return A user-friendly String representation of the query results.
    --- End diff --
    
    I see further down that you actually have an idea about what should be in a 
query result. Like, timing information and stuff. You might want to actually 
return an object with all of that in it here (and maybe add paging), then 
format what it will look like in the console code.


> Add Loading Data and Executing SPARQL Queries to the Rya Shell
> --------------------------------------------------------------
>
>                 Key: RYA-318
>                 URL: https://issues.apache.org/jira/browse/RYA-318
>             Project: Rya
>          Issue Type: Sub-task
>          Components: clients
>            Reporter: Jeff Dasch
>            Assignee: Jeff Dasch
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to