[
https://issues.apache.org/jira/browse/RYA-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105470#comment-16105470
]
ASF GitHub Bot commented on RYA-318:
------------------------------------
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/188#discussion_r130143520
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/client/ExecuteSparqlQuery.java
---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.api.client;
+
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;
+
+/**
+ * Loads a SPARQL Query and executes the query against an instance of Rya.
+ */
+@DefaultAnnotation(NonNull.class)
+public interface ExecuteSparqlQuery {
+ /**
+ * Loads a SPARQL Query and executes the query against an instance of
Rya.
+ *
+ * @param ryaInstanceName - The name of the Rya instance the query
will be executed against. (not null)
+ * @param sparqlQuery - A single SPARQL Query. (not null)
+ * @return A user-friendly String representation of the query results.
--- End diff --
What if thousands of results are returned by the query? Tens of thousands?
More? This interface doesn't suggest any sort of pagination over the search
results, so I'd worry that it'll load everything into memory and format it as a
single String for output. It also must force some sort of display format within
the interface. Seems like it would be a little more flexible if the interface
returned an iterator over BindingSets that are the results of the query.
> Add Loading Data and Executing SPARQL Queries to the Rya Shell
> --------------------------------------------------------------
>
> Key: RYA-318
> URL: https://issues.apache.org/jira/browse/RYA-318
> Project: Rya
> Issue Type: Sub-task
> Components: clients
> Reporter: Jeff Dasch
> Assignee: Jeff Dasch
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
