slievrly commented on code in PR #7397:
URL: https://github.com/apache/incubator-seata/pull/7397#discussion_r2121320254
##########
server/src/test/java/org/apache/seata/server/session/FileSessionManagerTest.java:
##########
@@ -470,12 +470,16 @@ public void changeGlobalSessionTest(List<GlobalSession>
globalSessions) throws E
Assertions.assertThrows(IllegalArgumentException.class, () ->
globalSessionService.changeGlobalStatus(globalSessions.get(0).getXid()));
+ Assertions.assertEquals(GlobalStatus.Begin,
globalSessions.get(0).getStatus());
+
GlobalSession globalSession = globalSessions.get(1);
- globalSession.changeGlobalStatus(GlobalStatus.CommitFailed);
String xid = globalSession.getXid();
-// Assertions.assertThrows(ConsoleException.class, () ->
globalSessionService.changeGlobalStatus(xid));
- globalSession.changeGlobalStatus(GlobalStatus.RollbackFailed);
- Assertions.assertThrows(ConsoleException.class, () ->
globalSessionService.changeGlobalStatus(xid));
+
+ globalSession.changeGlobalStatus(GlobalStatus.CommitFailed);
+ SingleResult<Void> singleResult =
globalSessionService.changeGlobalStatus(xid);
+
+ Assertions.assertTrue(singleResult.isSuccess());
+ Assertions.assertEquals(GlobalStatus.Committed,
globalSession.getStatus());
Review Comment:
The failing unit tests run successfully locally, but encounter failures in
the CI environment. The primary cause of failures is concurrency conflicts
during test execution. After analyzing recent failed and successful CI test
runs, a common factor among the failed tests is that the failing modules and
the seata-namingserver module were executed in parallel. In successful CI
pipelines, the execution order of seata-namingserver differs compared to failed
pipelines.
Failed CI Test Runs:
Building seata-namingserver 2.5.0-SNAPSHOT 2.5.0-SNAPSHOT [46/95]
https://productionresultssa19.blob.core.windows.net/actions-results/83180f59-5dd1-4580-8fab-ecbd533fc7db/workflow-job-run-a61cbcdc-67ab-53c0-e38e-eb145948c9c8/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-06-02T14%3A28%3A09Z&sig=XV8KixW%2BzJw%2FAq3iVJE0gZ5mi%2Be844H185q%2F9n45nj0%3D&ske=2025-06-03T02%3A05%3A08Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-06-02T14%3A05%3A08Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-06-02T14%3A18%3A04Z&sv=2025-05-05
https://productionresultssa8.blob.core.windows.net/actions-results/42d9725b-eeaf-4b7f-bcbb-aa1326e04c30/workflow-job-run-a61cbcdc-67ab-53c0-e38e-eb145948c9c8/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-06-02T14%3A27%3A29Z&sig=%2BmRaZp4PdTs3y2f5ASIqWs8S%2F9i%2BRhqjP4X8zI%2BA2Vc%3D&ske=2025-06-03T02%3A11%3A30Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-06-02T14%3A11%3A30Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-06-02T14%3A17%3A24Z&sv=2025-05-05
https://productionresultssa10.blob.core.windows.net/actions-results/20924427-f5e2-4d8c-b56a-b7d9fb10883e/workflow-job-run-a61cbcdc-67ab-53c0-e38e-eb145948c9c8/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-06-02T14%3A26%3A25Z&sig=qqpeIUAPM8vvwM7aXE51WtRAzg8qAELvcExM2AX%2ByDc%3D&ske=2025-06-03T02%3A11%3A46Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-06-02T14%3A11%3A46Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-06-02T14%3A16%3A20Z&sv=2025-05-05
---
Successful CI Test Runs:
Building seata-namingserver 2.5.0-SNAPSHOT 2.5.0-SNAPSHOT [80/95]
https://productionresultssa4.blob.core.windows.net/actions-results/b9f7981b-dfb8-4455-bc2c-4818172d2177/workflow-job-run-a61cbcdc-67ab-53c0-e38e-eb145948c9c8/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-06-02T14%3A25%3A45Z&sig=VFvYuzl%2BlJtBLjQnm92wbi8ulOcxzIS%2FOptsHVckjWs%3D&ske=2025-06-03T02%3A05%3A12Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-06-02T14%3A05%3A12Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-06-02T14%3A15%3A40Z&sv=2025-05-05
https://productionresultssa18.blob.core.windows.net/actions-results/a550f61a-b8f9-4bb1-ba7a-ecaf0de03ea8/workflow-job-run-a61cbcdc-67ab-53c0-e38e-eb145948c9c8/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-06-02T14%3A22%3A21Z&sig=C3y1GMxnCrjfN2aCKT4XEF6A7ih6qdWrFQ7zwqoRNz4%3D&ske=2025-06-03T02%3A11%3A36Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-06-02T14%3A11%3A36Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-06-02T14%3A12%3A16Z&sv=2025-05-05
https://productionresultssa8.blob.core.windows.net/actions-results/2828a27a-15ce-4679-9aa0-4746f6d785e2/workflow-job-run-a61cbcdc-67ab-53c0-e38e-eb145948c9c8/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-06-02T14%3A24%3A55Z&sig=JyhVNNIjM1eBEBalIYmB7A%2BnEDe2iaJvAu9GfVfrexo%3D&ske=2025-06-03T02%3A05%3A17Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-06-02T14%3A05%3A17Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-06-02T14%3A14%3A50Z&sv=2025-05-05
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
