YongGoose commented on code in PR #7397:
URL: https://github.com/apache/incubator-seata/pull/7397#discussion_r2122889304
##########
server/src/test/java/org/apache/seata/server/session/FileSessionManagerTest.java:
##########
@@ -470,12 +470,16 @@ public void changeGlobalSessionTest(List<GlobalSession>
globalSessions) throws E
Assertions.assertThrows(IllegalArgumentException.class, () ->
globalSessionService.changeGlobalStatus(globalSessions.get(0).getXid()));
+ Assertions.assertEquals(GlobalStatus.Begin,
globalSessions.get(0).getStatus());
+
GlobalSession globalSession = globalSessions.get(1);
- globalSession.changeGlobalStatus(GlobalStatus.CommitFailed);
String xid = globalSession.getXid();
-// Assertions.assertThrows(ConsoleException.class, () ->
globalSessionService.changeGlobalStatus(xid));
- globalSession.changeGlobalStatus(GlobalStatus.RollbackFailed);
- Assertions.assertThrows(ConsoleException.class, () ->
globalSessionService.changeGlobalStatus(xid));
+
+ globalSession.changeGlobalStatus(GlobalStatus.CommitFailed);
+ SingleResult<Void> singleResult =
globalSessionService.changeGlobalStatus(xid);
+
+ Assertions.assertTrue(singleResult.isSuccess());
+ Assertions.assertEquals(GlobalStatus.Committed,
globalSession.getStatus());
Review Comment:
> This issue is currently blocking the release of version 2.4.0. As a
short-term mitigation, we can temporarily resolve it by controlling the
execution order of unit tests to avoid concurrency conflicts. In the long term,
we need to implement robust support for concurrent multi-module testing.
@slievrly @funky-eyes
Would it be better to create a separate issue for this?
If you have any suggestions or ideas on how to approach it, I’d really
appreciate your comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
