slievrly commented on code in PR #7421:
URL: https://github.com/apache/incubator-seata/pull/7421#discussion_r2134756709


##########
.github/workflows/build.yml:
##########
@@ -84,6 +84,32 @@ jobs:
                  -Dcheckstyle.skip=false -Dpmd.skip=false -Dlicense.skip=false 
-DredisCaseEnabled=true \
                  -e -B 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
       # step 6.2
+      - name: "Print PMD Violation XML Details"
+        if: matrix.java == '8' && always()
+        run: |
+          echo "--- Searching for and printing PMD XML reports with violations 
across all modules ---"

Review Comment:
   https://github.com/apache/incubator-seata/blob/2.x/pom.xml#L419-L462



##########
.github/workflows/build.yml:
##########
@@ -84,6 +84,32 @@ jobs:
                  -Dcheckstyle.skip=false -Dpmd.skip=false -Dlicense.skip=false 
-DredisCaseEnabled=true \
                  -e -B 
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
       # step 6.2
+      - name: "Print PMD Violation XML Details"
+        if: matrix.java == '8' && always()
+        run: |
+          echo "--- Searching for and printing PMD XML reports with violations 
across all modules ---"

Review Comment:
   all modules? When PMD check encounters the first module that does not meet 
expectations, it will fail on error and print the error message. And the 
remaining modules will not continue to be executed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to