YoWuwuuuw commented on code in PR #7421:
URL: https://github.com/apache/incubator-seata/pull/7421#discussion_r2135050547
##########
.github/workflows/build.yml:
##########
@@ -84,6 +84,32 @@ jobs:
-Dcheckstyle.skip=false -Dpmd.skip=false -Dlicense.skip=false
-DredisCaseEnabled=true \
-e -B
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
# step 6.2
+ - name: "Print PMD Violation XML Details"
+ if: matrix.java == '8' && always()
+ run: |
+ echo "--- Searching for and printing PMD XML reports with violations
across all modules ---"
Review Comment:
This is indeed my problem. By downloading the log and filtering the
keywords, it can be found that the log is printed as INFO level!
I think we can optimize the mvn command to make the pmd failure log ERROR
level, as follows:
```
run: |
./mvnw -T 4C clean test \
-Dcheckstyle.skip=false -Dpmd.skip=false
-Dlicense.skip=false -DredisCaseEnabled=true \
-e -B \
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
\
-Dorg.slf4j.simpleLogger.log.net.sourceforge.pmd=error;
```
What do you think @slievrly
Finally, this pr will be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
