YongGoose commented on code in PR #7505:
URL: https://github.com/apache/incubator-seata/pull/7505#discussion_r2191491996
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -137,6 +140,13 @@ public void init() {
new NamedThreadFactory(getThreadPrefix(),
MAX_MERGE_SEND_THREAD));
mergeSendExecutorService.submit(new MergedSendRunnable());
}
+ reconnectExecutor = new ThreadPoolExecutor(
Review Comment:
IMO, creating a new thread pool is generally preferred when there’s a
high-priority task or when real-time processing is critical. Also, how
frequently the issue occurs can be an important factor in deciding whether to
create a new thread pool.
From a simple traceability standpoint, the current `timeoutExecutor` is used
in several places — such as handling reconnections and removing timed-out
messages.
So, it might make sense to update the prefix to something more general that
fits well across all these usages, and reuse it accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
