Dltmd202 commented on code in PR #7505:
URL: https://github.com/apache/incubator-seata/pull/7505#discussion_r2193707103
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -137,6 +140,13 @@ public void init() {
new NamedThreadFactory(getThreadPrefix(),
MAX_MERGE_SEND_THREAD));
mergeSendExecutorService.submit(new MergedSendRunnable());
}
+ reconnectExecutor = new ThreadPoolExecutor(
Review Comment:
Thanks for pointing that out. I revisited the issue and I now see your point
more clearly — reusing timeoutExecutor makes sense, especially since it’s
already used for similar tasks like handling reconnections and timeouts.
Avoiding an extra thread pool also helps keep things lean and easier to manage.
I’ll go ahead and update the code to reuse timeoutExecutor accordingly.
Appreciate the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
