tanzegen commented on code in PR #849:
URL:
https://github.com/apache/incubator-seata-go/pull/849#discussion_r2218053133
##########
pkg/tm/transaction_executor.go:
##########
@@ -73,8 +73,17 @@ func WithGlobalTx(ctx context.Context, gc *GtxConfig,
business CallbackWithCtx)
}
}
- if re != nil || err != nil {
- re = fmt.Errorf("first phase error: %v, second phase
error: %v", re, err)
Review Comment:
I changed the exception ultimately returned by WithGlobalTx to the exception
expected to be returned by business func. This might facilitate some additional
handling of the exception by the downstream, such as errors.Is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
