tanzegen commented on code in PR #849:
URL:
https://github.com/apache/incubator-seata-go/pull/849#discussion_r2268897128
##########
pkg/tm/transaction_executor.go:
##########
@@ -73,8 +73,18 @@ func WithGlobalTx(ctx context.Context, gc *GtxConfig,
business CallbackWithCtx)
}
}
- if re != nil || err != nil {
- re = fmt.Errorf("first phase error: %v, second phase
error: %v", re, err)
+ if re == nil {
+ if deferErr != nil {
+ // if deferErr is not an error, then convert it
to error
+ // this is because panic may be caused by
non-error type e.g. panic("some string")
+ // so we need to convert it to error type
+ if _, ok := deferErr.(error); !ok {
+ deferErr = fmt.Errorf("%v", deferErr)
+ }
+ re = deferErr.(error)
Review Comment:
Removing assertions will result in type errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
