YvCeung commented on code in PR #7765:
URL: https://github.com/apache/incubator-seata/pull/7765#discussion_r2490457503
##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -155,6 +157,28 @@ public AbstractNettyRemotingClient(
clientBootstrap.setChannelHandlers(new ClientHandler(), new
ChannelEventHandler(this));
clientChannelManager = new NettyClientChannelManager(
new NettyPoolableFactory(this, clientBootstrap),
getPoolKeyFunction(), nettyClientConfig);
+
+ Configuration configuration = ConfigurationFactory.getInstance();
+ this.enableReconnect =
+ configuration.getBoolean("client.reconnect.enable",
DefaultValues.DEFAULT_ENABLE_CLIENT_RECONNECT);
+
Review Comment:
Although there is currently a passive reconnection mechanism (on-demand
reconnection), it inevitably increases request latency, as the connection is
only detected and re-established when a request is actually sent. I would like
to understand: if the scheduled reconnection switch is disabled, are there any
other negative impacts beyond the increased request latency? Additionally, is
it necessary to give users the decision-making authority over this switch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
