maple525866 commented on code in PR #7765: URL: https://github.com/apache/incubator-seata/pull/7765#discussion_r2517372034
########## core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java: ########## Review Comment: Is there a risk of resource leaks here? Currently, `destroy()` only removes the instance from `CLIENT_INSTANCES`, but does not stop `GLOBAL_RECONNECT_TIMER` when there are no instances. Even if all clients are destroyed, the scheduler remains alive and occupies threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
