terrymanu commented on a change in pull request #3906: Make the shadow feature
more complete
URL:
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r364640621
##########
File path:
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
##########
@@ -169,6 +182,6 @@ public void setHoldability(final int holdability) throws
SQLException {
@Override
public int getHoldability() {
- return 0;
+ return ResultSet.CLOSE_CURSORS_AT_COMMIT;
Review comment:
Is it correct for default value forever?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
