[GitHub] [incubator-shardingsphere] yanyzy commented on a change in pull request #3906: Make the shadow feature more complete

[GitBox]

yanyzy commented on a change in pull request #3906: Make the shadow feature 
more complete
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3906#discussion_r365095228
 
 

 ##########
 File path: 
sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/connection/ShadowConnection.java
 ##########
 @@ -93,13 +102,14 @@ public PreparedStatement prepareStatement(final String 
sql, final String[] colum
     
     @Override
     public void setAutoCommit(final boolean autoCommit) throws SQLException {
+        this.autoCommit = autoCommit;
         actualConnection.setAutoCommit(autoCommit);
         shadowConnection.setAutoCommit(autoCommit);
     }
     
     @Override
     public boolean getAutoCommit() {
-        return false;
+        return autoCommit;
 
 Review comment:
   getAutoCommit()、isClosed()、isReadOnly() extends from Connection interface , 
can not use 
    lombok's @getter to instead of them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services