surukonda commented on code in PR #23954:
URL: https://github.com/apache/shardingsphere/pull/23954#discussion_r1095457303
##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/postgresql/executor/PostgreSQLSetCharsetExecutor.java:
##########
@@ -34,7 +34,7 @@ public final class PostgreSQLSetCharsetExecutor implements
PostgreSQLSessionVari
@Override
public void handle(final ConnectionSession connectionSession, final String
variableName, final String assignValue) {
- String value = formatValue(assignValue.trim());
Review Comment:
Ah! that was miss, it is removed now in the updated PR.
##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/postgresql/executor/PostgreSQLSetCharsetExecutor.java:
##########
@@ -34,7 +34,7 @@ public final class PostgreSQLSetCharsetExecutor implements
PostgreSQLSessionVari
@Override
public void handle(final ConnectionSession connectionSession, final String
variableName, final String assignValue) {
- String value = formatValue(assignValue.trim());
+ String value = assignValue.trim();
connectionSession.getAttributeMap().attr(CommonConstants.CHARSET_ATTRIBUTE_KEY).set(parseCharset(value));
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
