surukonda commented on code in PR #23954:
URL: https://github.com/apache/shardingsphere/pull/23954#discussion_r1095457483
##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/admin/postgresql/PostgreSQLCharacterSets.java:
##########
@@ -107,7 +107,18 @@ public enum PostgreSQLCharacterSets {
* @return corresponding {@link Charset}
*/
public static Charset findCharacterSet(final String charsetName) {
- PostgreSQLCharacterSets result =
CHARACTER_SETS_MAP.get(charsetName.toUpperCase());
- return null != result && null != result.charset ? result.charset :
Charset.forName(charsetName);
+ String formattedCharsetName = formatValue(charsetName);
+ PostgreSQLCharacterSets result =
CHARACTER_SETS_MAP.get(formattedCharsetName.toUpperCase());
+ return null != result && null != result.charset ? result.charset :
Charset.forName(formattedCharsetName);
+ }
+
+ /**
+ * Find corresponding {@link Charset} by charset name defined in
PostgreSQL.
+ *
+ * @param value that needs to be formatted
+ * @return formatted string without any single/double quotes {@link String}
+ */
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
