ym0506 opened a new pull request, #38326: URL: https://github.com/apache/shardingsphere/pull/38326
Fixes #37282. Changes proposed in this pull request: - Normalize `Long` and `BigInteger` sharding values (only when they are in integer range) to integer semantics before hashing in `HashModShardingAlgorithm`. - Keep the existing `hashCode()` behavior for out-of-integer-range values and non-target types to minimize compatibility impact. - Add regression tests in `HashModShardingAlgorithmTest` to verify that `Integer(-1)`, `Long(-1)`, and `BigInteger(-1)` route to the same shard. - Update `ShardingSphereDriverTest#assertHashModSetLongOnIntColumnWorks` to use `-1` and remove the TODO as end-to-end verification. --- Before committing this PR, I'm sure that I have checked the following options: - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project. - [x] I have self-reviewed the commit code. - [ ] I have (or in comment I request) added corresponding labels for the pull request. - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. - [ ] I have made corresponding changes to the documentation. - [x] I have added corresponding unit tests for my changes. - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/) Local verification executed: - `./mvnw -pl features/sharding/core -am -Dtest=HashModShardingAlgorithmTest -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw -pl jdbc -am -Dtest=ShardingSphereDriverTest#assertHashModSetLongOnIntColumnWorks -Dsurefire.failIfNoSpecifiedTests=false test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
