ym0506 commented on PR #38327: URL: https://github.com/apache/shardingsphere/pull/38327#issuecomment-3995259413
Thanks for the detailed review. I addressed both requested points in commit `f9379dea`. What was updated: 1. Compatibility handling - Added `HASH_MOD` property `normalize-numeric-int-range`. - Default is `false` (legacy behavior) to avoid cross-version routing drift after upgrade. - Normalized numeric routing consistency is now opt-in (`true`). 2. Test adequacy improvements - Added legacy-mode regression for `Integer(-1)` vs `Long(-1)` routing difference. - Added normalized-mode regression for `Integer/Long/BigInteger(-1)` consistency. - Added `BigInteger` boundary tests (`Integer.MIN_VALUE`, `Integer.MAX_VALUE`). - Added `BigInteger` out-of-int-range compatibility-path tests. Additional updates: - Updated HASH_MOD docs (EN/CN) with the new property. - Updated the PR description with compatibility/migration note and verification mapping. Verification rerun: - `./mvnw -pl features/sharding/core -am -Dtest=HashModShardingAlgorithmTest -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw -pl jdbc -am -Dtest=ShardingSphereDriverTest#assertHashModSetLongOnIntColumnWorks -Dsurefire.failIfNoSpecifiedTests=false test` Please help take another look. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
