tristaZero edited a comment on pull request #6359: URL: https://github.com/apache/shardingsphere/pull/6359#issuecomment-659813723
Hi @SirMin Very appreciated your PR! Since this PR will change the public API to users, so we need to be serious about it. @terrymanu gave his opinion that if users call `getInstance()` in different threads and get the same instance, it is not safe to do modification on the same one. Besides, `getInstance()` is similar to `getConnection()`, which will return a new one to users. Back to your need, maybe you can consider passing the `HintManager` by function parameters. Therefore, I have to close this PR, and welcome your succeeding joining! :-) Best, Trista ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
