SirMin edited a comment on pull request #6359:
URL: https://github.com/apache/shardingsphere/pull/6359#issuecomment-667620255
My point is that these restrictions should be pointed out in the
documentation.
The user has been able to obtain the HintManager object, but the user does
not
know whether the implementation details of the HintManager are reasonable?
Because
ShardingJdbc can no longer restrict users from using HintManager
instances.My point
is that users don’t need to know the specific implementation logic, but they
should
know how to implement it.
So the documentation of the user-oriented api is very important.
However, there
is no mention of the relationship between HintManager and threads in the
HintManager
documentation. Because the more intuitive relationship should be Connection
and
HintManager one-to-one correspondence or Statemant and HintManager
one-to-one
correspondence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
