wgy8283335 commented on a change in pull request #8310:
URL: https://github.com/apache/shardingsphere/pull/8310#discussion_r532296876
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/dml/impl/ShardingInsertStatementValidator.java
##########
@@ -62,6 +78,9 @@ public void preValidate(final ShardingRule shardingRule,
final SQLStatementConte
if (insertSelectSegment.isPresent() &&
!isAllSameTables(tablesContext.getTableNames()) &&
!shardingRule.isAllBindingTables(tablesContext.getTableNames())) {
throw new ShardingSphereException("The table inserted and the
table selected must be the same or bind tables.");
}
+ if (insertSelectSegment.isPresent() &&
isNeedMergeShardingValues(sqlStatementContext, shardingRule)) {
+ checkSubqueryShardingValues(shardingRule, sqlStatementContext,
parameters, schema);
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
