TeslaCN commented on code in PR #19876:
URL: https://github.com/apache/shardingsphere/pull/19876#discussion_r938409453
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/lock/manager/ShardingSphereDistributedLockManagerTest.java:
##########
@@ -62,16 +61,16 @@ public void assertGetDistributedLock() {
@Test
public void assertTryReadLock() {
- assertTrue(shardingSphereDistributedLockManager.tryLock(new
DatabaseLockDefinition(new DatabaseLockNameDefinition("databaseName")), 3000L));
+ assertTrue(shardingSphereDistributedLockManager.tryLock(new
DatabaseLockDefinition("databaseName"), 3000L));
}
@Test
public void assertReleaseLock() {
- shardingSphereDistributedLockManager.releaseLock(new
DatabaseLockDefinition(new DatabaseLockNameDefinition("databaseName")));
+ shardingSphereDistributedLockManager.releaseLock(new
DatabaseLockDefinition("databaseName"));
Review Comment:
Missing assertion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
