soulasuna commented on code in PR #19876:
URL: https://github.com/apache/shardingsphere/pull/19876#discussion_r938413193
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/lock/LockContext.java:
##########
@@ -51,17 +44,17 @@ default void initLockState(InstanceContext instanceContext)
{
* Try Lock.
*
* @param lockDefinition lock definition
- * @param timeoutMilliseconds timeout milliseconds
+ * @param timeoutMillis timeout milliseconds
* @return is locked or not
*/
- boolean tryLock(LockDefinition lockDefinition, long timeoutMilliseconds);
+ boolean tryLock(LockDefinition lockDefinition, long timeoutMillis);
/**
- * Release lock.
+ * Un lock.
Review Comment:
It will fix in next pr.
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/lock/manager/ShardingSphereDistributedLockManagerTest.java:
##########
@@ -62,16 +61,16 @@ public void assertGetDistributedLock() {
@Test
public void assertTryReadLock() {
- assertTrue(shardingSphereDistributedLockManager.tryLock(new
DatabaseLockDefinition(new DatabaseLockNameDefinition("databaseName")), 3000L));
+ assertTrue(shardingSphereDistributedLockManager.tryLock(new
DatabaseLockDefinition("databaseName"), 3000L));
}
@Test
public void assertReleaseLock() {
- shardingSphereDistributedLockManager.releaseLock(new
DatabaseLockDefinition(new DatabaseLockNameDefinition("databaseName")));
+ shardingSphereDistributedLockManager.releaseLock(new
DatabaseLockDefinition("databaseName"));
Review Comment:
It will fix in next pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
