taojintianxia commented on code in PR #20021:
URL: https://github.com/apache/shardingsphere/pull/20021#discussion_r941945017
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/storage/DockerStorageContainer.java:
##########
@@ -50,14 +50,17 @@ public abstract class DockerStorageContainer extends
DockerITContainer implement
@Getter(AccessLevel.NONE)
private final String scenario;
+ private final String module;
+
private final Map<String, DataSource> actualDataSourceMap;
private final Map<String, DataSource> expectedDataSourceMap;
- public DockerStorageContainer(final DatabaseType databaseType, final
String dockerImageName, final String scenario) {
+ public DockerStorageContainer(final DatabaseType databaseType, final
String dockerImageName, final String scenario, final String module) {
Review Comment:
and for the combination for modue and scenario. I prefer to design a
InitStrategy. like MySQLScalingStrategy, the content of the strategy in this
module will implement by scaling developer, they will decide how to init
storage type cotnainer , if this is no special init strategy, we will provide a
MySQLDefaultStrategy which just init a common my.cnf and related init sql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
