taojintianxia commented on code in PR #20021:
URL: https://github.com/apache/shardingsphere/pull/20021#discussion_r941949871
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/storage/DockerStorageContainer.java:
##########
@@ -50,14 +50,17 @@ public abstract class DockerStorageContainer extends
DockerITContainer implement
@Getter(AccessLevel.NONE)
private final String scenario;
+ private final String module;
+
private final Map<String, DataSource> actualDataSourceMap;
private final Map<String, DataSource> expectedDataSourceMap;
- public DockerStorageContainer(final DatabaseType databaseType, final
String dockerImageName, final String scenario) {
+ public DockerStorageContainer(final DatabaseType databaseType, final
String dockerImageName, final String scenario, final String module) {
Review Comment:
> The module is not make sense, the basic module should not know other
module name. How about merge module and scenario?
after all container management and config reclaimed in env, this may
refactored as a`StorageContainerContext` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
