BFergerson edited a comment on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472654046 @wu-sheng, I think I have a firm grasp of the problem now lol. Instead of modifying the `endTime` why not just wait to close the span? I understand that waiting to close the span won't work with `TracingContext` but that's because it deals with one segment at a time. A new `TracingContext` implementation could work with multiple segments at a time requiring a key to choose which segment the spans belong to. I think with an implementation like this I could delay closing the `EntrySpan` until the response is sent (how I was doing it before). That also lets the process for all the `TracingContext` implementations remain essentially the same and this multiple segments/asynchronous one doesn't have extra look back logic.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
