Humbertzhang commented on a change in pull request #13:
URL:
https://github.com/apache/skywalking-infra-e2e/pull/13#discussion_r591488656
##########
File path: internal/components/setup/common.go
##########
@@ -64,6 +64,13 @@ func RunCommandsAndWait(runs []config.Run, timeout
time.Duration) error {
return nil
}
+// parseRunCommand parses command lines to individual commands.
+func parseRunCommand(command string) (commands []string) {
+ replacedCommand := strings.ReplaceAll(command, "\\\n", " ")
+ commands = strings.Split(replacedCommand, "\n")
+ return commands
+}
+
Review comment:
I think running commands separately can lets the user know what command
is wrong when something exception happen. What do u think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
