wu-sheng commented on pull request #50: URL: https://github.com/apache/skywalking-nodejs/pull/50#issuecomment-839764854
> > > "peer" removed from Context.newExitSpan() and is now treated just like the other parameters. > > > > > > If there is no `peer`, the `sw8` header could not be assembled correctly. How do the test cases work? > > There is a peer it is just being set explicitly after the call rather than passing as parameter to `newExitSpan()` and being set in this function. A minor change to allow consolidating common functionality of newExitSpan, newEntrySpan and newLocalSpan. This was designed from day one, because you want to make sure you have this, rather than facing `no-peer` in creating headers. Do we expect to have an `error` if it is really missed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
