wu-sheng commented on pull request #50:
URL: https://github.com/apache/skywalking-nodejs/pull/50#issuecomment-839786757


   > > I think should have a setting called `config.sampling=adaptive`, then 
your codes work. Also, we could extend to have `config-sampling=rate` etc.
   > 
   > In this PR I only changed how the current sampling method is implemented, 
not how it is defined, but those are all ideas for future PR extensions. One 
idea might be a general rule system for this and the various "ignore" options 
which specifies which endpoints to record and which to exclude which might 
include sampling frequency and max counts. But again, that is for a future PR...
   
   Could you update the document about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to