constanine commented on pull request #488:
URL: 
https://github.com/apache/skywalking-rocketbot-ui/pull/488#issuecomment-843758788


   > I only write several comments here. You can't find lint errors as you use 
`js` to code, rather than `ts`. **Please use `ts`.**
   > `<script lang="ts">.....</script>`
   > 
   > When I input page number, here always find this error.
   > 
![1](https://user-images.githubusercontent.com/20871783/118656765-69970780-b81d-11eb-935a-36e89d2a8c30.png)
   > 
   > demo env works well
   > 
![2](https://user-images.githubusercontent.com/20871783/118657023-a6fb9500-b81d-11eb-8859-7497559b4b18.png)
   
   I see 
src/views/components/common/trace-detail-chart-table.vue,src/views/components/trace/trace-detail-chart-list.vue,
   src/views/components/trace/trace-detail-chart-tree.vue all just use `<script 
lang="js">.....</script>` not  `<script lang="ts">.....</script>`, Are you sure 
to use `<script lang="ts">.....</script>`? And are you ready to have a plan 
which change them to use  `<script lang="ts">.....</script>`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to