constanine commented on pull request #488: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/488#issuecomment-843811023
> I only write several comments here. You can't find lint errors as you use `js` to code, rather than `ts`. **Please use `ts`.** > `<script lang="ts">.....</script>` > > When I input page number, here always find this error. >  > > demo env works well >  I see src/views/components/common/trace-detail-chart-table.vue,src/views/components/trace/trace-detail-chart-list.vue, src/views/components/trace/trace-detail-chart-tree.vue and lmost all the *.vue just use `<script lang="js">.....</script>` not `<script lang="ts">.....</script>`, Are you sure to use `<script lang="ts">.....</script>`? And are you ready to have a plan which change them to use `<script lang="ts">.....</script>`? And if I use `<script lang="ts">.....</script>` it need all the *.vue to use `<script lang="ts">.....</script>`! I think this should be an other PR, not mime ! How do you think @ > I don't know UI details. @Fine0830 makes the call. > > @constanine I need to remind you, from reviewer's perspective, to focus on the codes you proposed, don't challenge the existing codes not changed. Those are 2 separate things. Beasuse of almost views/component/*.vue need to change, if is ts we can't debugger in browser,and if type is js,we can debugger in browser, and not I think this ui juse ui for browser not for server, this project just build a dist and player with java web application ,so it need ts?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
