pg-yang commented on code in PR #9622: URL: https://github.com/apache/skywalking/pull/9622#discussion_r973584116
########## test/e2e-v2/cases/storage/storage-cases.yaml: ########## @@ -47,7 +47,7 @@ cases: - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls expected: expected/traces-list.yml # negative tags search: relationship should be logical AND instead of logical OR - - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags http.method=POST,http.status_code=200 + - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags http.method=POST,http.status_code=200,iserror=true Review Comment: According the comment in this test case and the expected data , `negative ` means query nothing . The previous java agent collect the status_code which max 400 , so the test case could match expected data . But the latest java agent collect all http code (include 200), In order to match expected data , I added the param You could find this PR https://github.com/apache/skywalking-java/pull/258 BTW , I don't know the meaning of this cache , I'm just keeping this case logically correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
