wu-sheng commented on code in PR #9622: URL: https://github.com/apache/skywalking/pull/9622#discussion_r973584608
########## test/e2e-v2/cases/storage/storage-cases.yaml: ########## @@ -47,7 +47,7 @@ cases: - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls expected: expected/traces-list.yml # negative tags search: relationship should be logical AND instead of logical OR - - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags http.method=POST,http.status_code=200 + - query: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql trace ls --tags http.method=POST,http.status_code=200,iserror=true Review Comment: statu_code=200, isn't `iserror` should be `false`? And `is_error` should be a parameter, rather than a tag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
