pg-yang commented on code in PR #9813:
URL: https://github.com/apache/skywalking/pull/9813#discussion_r999160001
##########
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/AggregationFuncStmt.java:
##########
@@ -49,22 +50,23 @@ public ConditionExpression getNextFuncConditionExpression()
{
return funcConditionExpressions.get(funcConditionExpressionGetIdx++);
}
- public void addFuncArg(Argument argument) {
+ public void addFuncArg(Argument... argument) {
Review Comment:
> you still don't have funcParamExpression
Yes , I would confirm it .
> About the array type
Actually , I want to build the type of array based on the parameter type ,
which will support base-type , such as StringArray , intArray，doubleArray， etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
