wu-sheng commented on code in PR #9813:
URL: https://github.com/apache/skywalking/pull/9813#discussion_r999192153
##########
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/AggregationFuncStmt.java:
##########
@@ -49,22 +50,23 @@ public ConditionExpression getNextFuncConditionExpression()
{
return funcConditionExpressions.get(funcConditionExpressionGetIdx++);
}
- public void addFuncArg(Argument argument) {
+ public void addFuncArg(Argument... argument) {
Review Comment:
But, there is an issue about this. `SourceFrom` should be for `getting field
value from a source's attribute`, and `Arg` should be a kind of literal
declared from the OAL.
Now, my question would be, can't we build a field in the source including
key-value pairs directly? And use `SourceFrom` rather than adding this
complexity for the OAL? We are not really building an array mixed with
attribute values and literal strings, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
