tjiuming opened a new pull request, #405:
URL: https://github.com/apache/skywalking-java/pull/405

   Currently, we set `new MessageEnhanceRequiredInfo()` into `MessageImpl` to 
store the tracing context.
   But Pulsar has a Recycle mechanism, see: 
https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java#L126
   The `MessageImpl` will not GC by JVM, so the `new 
MessageEnhanceRequiredInfo()` settled into `MessageImpl` won't be GC too, it 
will lead to memory leak.
   The PR will clean the `new MessageEnhanceRequiredInfo()` settled into 
`MessageImpl` to prevent memory leak.
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to