wu-sheng commented on PR #405:
URL: https://github.com/apache/skywalking-java/pull/405#issuecomment-1340881970

   > we enhance ConsumerImpl#messageProccessed to generate Consumer/Receive 
event, but usually, the duration of executing ConsumerImpl#messageProccessed is 
veeeery short.
   uses are using 
Consumer#receive()/receive(long,TimeUnit)/receiveAsync()/batchReceive()/batchReceiveAsync()
 cannot get the actual duration
   
   About how to get the duration accurate, I think you are better than me. 
Pulsar plugin mostly was added in 2019, and there was no `async`-span concept 
back then. 
   Now, if you want to make a span duration accurate, we could open the span, 
and declare it is async and finish it in the callback or another thread when 
you need. The tracing context would be held by the agent kernel until you 
finish the span async. 
   
   Ref doc, 
https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/java-plugin-development-guide/#advanced-apis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to