[GitHub] [skywalking] wu-sheng commented on pull request #10202: Remove time_bucket tag for BanyanDB impl

Sun, 25 Dec 2022 20:01:49 -0800 


wu-sheng commented on PR #10202:
URL: https://github.com/apache/skywalking/pull/10202#issuecomment-1364856040

   > Just one remaining reference in `IProfileTaskQueryDAO`, currently it is 
possible that `startTimebucket` and `endTimeBucket` are both null @mrproliu 
@wu-sheng
   > 
   > 
![image](https://user-images.githubusercontent.com/2568208/209497823-0bd7369a-aa81-459e-85f5-6620eecf80ea.png)
   > 
   > 
![image](https://user-images.githubusercontent.com/2568208/209498009-9a3fc10e-5bd9-4672-a746-d07956fc82ba.png)
   
   I think it should not be both null. @mrproliu Please could you confirm the 
use case?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to