lujiajing1126 commented on code in PR #10202:
URL: https://github.com/apache/skywalking/pull/10202#discussion_r1057080862
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBConverter.java:
##########
@@ -229,6 +243,9 @@ public StorageToMeasure(MetadataRegistry.Schema schema,
DataPoint dataPoint) {
@Override
public Object get(String fieldName) {
+ if (fieldName.equals(Metrics.TIME_BUCKET)) {
Review Comment:
Yes. I think it should be moved to the base class. We may do this later? We
have a lot of references to these constants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
