mrproliu commented on code in PR #111:
URL:
https://github.com/apache/skywalking-query-protocol/pull/111#discussion_r1130642383
##########
profile.graphqls:
##########
@@ -156,6 +163,10 @@ extend type Query {
getProfileTaskSegmentList(taskID: String): [BasicTrace!]!
# query profiled segment
getProfiledSegment(segmentId: String): ProfiledSegment
+ # query combined segments by ref
+ getProfiledSegments(segmentIds: [String!]!): [ProfiledSegments!]!
Review Comment:
> > No verification, just query the segments and combine them when the
cross-thread segment matches with the parent segment. Then, The UI can show the
spans in the same process, and analyze the profiling results with the same
process(segment id list).
>
> I think UI is hard to verify things like `ref` linking segments. We may
only bind segments with trace ID belonging to one task ID. This should be
enough.
Do you mean to query all segments in the same trace? But there may have
multiple segments that are not profiled, so they cannot be analyzed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
