wu-sheng commented on code in PR #111:
URL:
https://github.com/apache/skywalking-query-protocol/pull/111#discussion_r1130643824
##########
profile.graphqls:
##########
@@ -156,6 +163,10 @@ extend type Query {
getProfileTaskSegmentList(taskID: String): [BasicTrace!]!
Review Comment:
@mrproliu How about UI enhancing this way,
1. Use this API, to group `segmentId`s by `traceId` and `Instance ID`(new
Added). Could our backend these without agent update?
2. `getProfiledSegments`(new APIs) to get `ProfiledSegment`s.
3. Build profiling.
The major differences with yours are
1. `getProfiledSegment` should be `deprecated`, only a shell(special
condition) to `getProfiledSegments`.
2. No new `ProfiledSegments`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
