wuwen5 commented on code in PR #555:
URL: https://github.com/apache/skywalking-java/pull/555#discussion_r1232047813
##########
apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-2.0.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v20x/HttpClientRequestInterceptor.java:
##########
@@ -80,7 +84,7 @@ public Publisher<Void> apply(final HttpClientRequest
httpClientRequest) {
}
};
- objInst.setSkyWalkingDynamicField(new EnhanceCacheObject(span,
abstractSpan));
+ ENHANCE_CONTEXT.set(new EnhanceCacheObject(span, abstractSpan));
Review Comment:
> The HttpClient instance is a singleton, and the setting and retrieval of
EnhanceCacheObject are not thread-safe. Therefore, the EnhanceCacheObject
obtained in the afterMethod may not necessarily be set by the same thread in
the beforeMethod.
In fact, this description is not correct, no need for threadlocal here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
