gzlicanyi commented on code in PR #555:
URL: https://github.com/apache/skywalking-java/pull/555#discussion_r1232061514
##########
apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-2.0.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v20x/HttpClientRequestInterceptor.java:
##########
@@ -80,7 +84,7 @@ public Publisher<Void> apply(final HttpClientRequest
httpClientRequest) {
}
};
- objInst.setSkyWalkingDynamicField(new EnhanceCacheObject(span,
abstractSpan));
+ ENHANCE_CONTEXT.set(new EnhanceCacheObject(span, abstractSpan));
Review Comment:
Reproduction steps:
In a high-concurrency scenario, the allArguments[1] is stored in
EnhanceCacheObject in the beforeMethod method, but in the afterMethod method,
the allArguments[1] of the method parameter is different from the
allArguments[1] in EnhanceCacheObject.
Similarly, the thread name can also be reproduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]