mrproliu commented on code in PR #104:
URL: https://github.com/apache/skywalking-go/pull/104#discussion_r1361735376
##########
tools/go-agent/instrument/plugins/instrument.go:
##########
@@ -107,8 +107,9 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
// check the version of the framework could handler
version, err := i.tryToFindThePluginVersion(opts, ins)
if err != nil {
- logrus.Warnf("ignore the plugin %s, because: %s",
ins.Name(), err)
- continue
+ // Local package (e.g. toolkit) does not have version.
Review Comment:
```suggestion
// Local package (e.g. replaced toolkit) does not have
version.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
