Ecostack commented on PR #104:
URL: https://github.com/apache/skywalking-go/pull/104#issuecomment-1774645846
Been testing the new version and found some things. First of all, this
feature looks amazing and I am happy about what it can provide! Please let me
know if this is the right place to post or not.
### Toolkit/Trace API
The package github.com/apache/skywalking-go v0.3.0 does not expose the
toolkit/trace API, it is a separate package.
Would it not be better if that is both coming from the skywalking-go package?
```
require (
github.com/apache/skywalking-go v0.3.0
github.com/apache/skywalking-go/toolkit
v0.0.0-20231019114202-ff7ad0ddecba
)
```
### No trace.SetLog
According to the documentation, there should be a log method on the trace.
It seems like it does not exist though. Either way, logging inside of a span is
correctly reported.
Maybe it is best to remove the trace.SetLog from the documentation?
### Injector & Extractor Ref
There are two methods, `CreateEntrySpan(operationName string, extractor
ExtractorRef)` and `CreateExitSpan(operationName string, peer string, injector
InjectorRef)` which require either an **injector or extractor ref**.
How would I obtain these or use these methods? Maybe provide an example of
how these can be used.
### Component unknown
Manual span entries have component value set to `unknown`. Can this be set
manually or would it be possible to set this value somehow automatic, maybe the
file name or such?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
