peachisai commented on PR #625: URL: https://github.com/apache/skywalking-java/pull/625#issuecomment-1776258046
> I didn't check the failed test cases. I feel as many other frameworks are using netty, you newly added a plugin for it could change the expected tracing data(spans or something). You should check the fail reason, if the reason is as I mentioned above, we should consider to put netty HTTP plugin as optional only. I have fixed some issues, and the other are just segment size errors.I agree to put the plugin into optional plugins. Some frameworks, such as Vert.x and Spring Cloud Gateway, use Netty as an HTTP server and they also have their own plugins. This could lead to duplicate collections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
