wu-sheng commented on code in PR #625: URL: https://github.com/apache/skywalking-java/pull/625#discussion_r1369424340
########## docs/en/setup/service-agent/java-agent/Supported-list.md: ########## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: ```suggestion * [Netty HTTP](https://github.com/netty/netty) 4.1.x (Optional¹) ``` I checked your test scenario, this plugin seems to work for both client and server of Netty? Am I right? If so, I feel it is better to put it inside `RPC` catalog. ########## docs/en/setup/service-agent/java-agent/Supported-list.md: ########## @@ -25,6 +25,7 @@ metrics based on the tracing data. * [Jersey REST framework](https://github.com/eclipse-ee4j/jersey) 2.x -> 3.x * [Grizzly](https://github.com/eclipse-ee4j/grizzly) 2.3.x -> 4.x * [WebSphere Liberty](https://github.com/OpenLiberty/open-liberty) 23.x + * [Netty HTTP](https://github.com/netty/netty) 4.1.x Review Comment: ```suggestion * [Netty HTTP](https://github.com/netty/netty) 4.1.x (Optional¹) ``` I checked your test scenario, this plugin seems to work for both client and server of Netty? Am I right? If so, I feel it is better to put it inside `RPC` catalog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
