wu-sheng commented on code in PR #11954:
URL: https://github.com/apache/skywalking/pull/11954#discussion_r1506958386


##########
docs/en/concepts-and-designs/service-hierarchy.md:
##########
@@ -162,6 +164,22 @@ If you want to customize it according to your own needs, 
please refer to [Servic
   - VIRTUAL_MQ.service.name: 
`rabbitmq.skywalking-showcase.svc.cluster.local:5672`
   - RABBITMQ.service.name: `rabbitmq::rabbitmq.skywalking-showcase`
 
+#### KAFKA On K8S_SERVICE
+- Rule name: `short-name`
+- Groovy script: `{ (u, l) -> u.shortName == l.shortName }`
+- Description: KAFKA.service.shortName == K8S_SERVICE.service.shortName
+- Matched Example:
+  - ROCKETMQ.service.name: `kafka::kafka.skywalking-showcase`
+  - K8S_SERVICE.service.name: `skywalking-showcase::kafka.skywalking-showcase`
+
+#### VIRTUAL_MQ On KAFKA
+- Rule name: `lower-short-name-with-fqdn`
+- Groovy script: `{ (u, l) -> u.shortName.substring(0, 
u.shortName.lastIndexOf(':')) == l.shortName.concat('.svc.cluster.local') }`
+- Description: VIRTUAL_MQ.service.shortName remove port == 
KAFKA.service.shortName with fqdn suffix
+- Matched Example:
+  - VIRTUAL_MQ.service.name: `kafka.skywalking-showcase.svc.cluster.local:9092`
+  - ROCKETMQ.service.name: `kafka::rocketmq.skywalking-showcase`

Review Comment:
   I mean you put `ROCKETMQ` in here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to